NavigationActivation prototype #42873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 31, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4990011
branch
8 times, most recently
from
f531992 to
c40447f
Compare
NavigationActivation is a new object (exposed as
`navigation.activation`). It is updated when a new Document is
"activated": initial Document creation, restore from bfcache, or
(in a future CL) prerender activation. It has three pieces of state:
* `activation.entry`: The current NavigationHistoryEntry at the time
of activation.
* `activation.from`: The current NavigationHistoryEntry immediately
before activation (i.e., the entry we came from). This will be
null if the navigation was cross-origin, or if the previous entry
was not in the same-origin contiguous region of the back/forward
list that is available in `navigation.entries()`.
* `activation.navigationType`: The navigationType ('push', 'replace',
'reload', or 'traverse') of the navigation that activated the
current Document.
Note that `entry` or `from` may be a NavigationHistoryEntry that is
no longer present in `navigation.entries()` (e.g., when doing a
replace navigation, `activation.from` will be the replaced entry).
In that case, the entry will remain visible, but because it is
a "disposed" entry, its index will be -1 and attempting to
`navigation.traverseTo()` its key will be rejected.
Initial discussion: whatwg/html#9760
Draft spec PR: whatwg/html#9856
I2p: https://groups.google.com/a/chromium.org/g/blink-dev/c/EfqxeH3Iwh4
Bug: 1492932
Change-Id: I2e090a8366906e4cb6778893ad9ffdca18d6ec37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4990011
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1220983}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4990011
branch
from
c40447f to
d29dc7c
Compare
|
Test failed due to this change: Unstable results
|
|
Create https://bugs.chromium.org/p/chromium/issues/detail?id=1500442 to track this issue. |
KyleJu
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationActivation is a new object (exposed as
navigation.activation). It is updated when a new Document is"activated": initial Document creation, restore from bfcache, or
(in a future CL) prerender activation. It has three pieces of state:
activation.entry: The current NavigationHistoryEntry at the timeof activation.
activation.from: The current NavigationHistoryEntry immediatelybefore activation (i.e., the entry we came from). This will be
null if the navigation was cross-origin, or if the previous entry
was not in the same-origin contiguous region of the back/forward
list that is available in
navigation.entries().activation.navigationType: The navigationType ('push', 'replace','reload', or 'traverse') of the navigation that activated the
current Document.
Note that
entryorfrommay be a NavigationHistoryEntry that isno longer present in
navigation.entries()(e.g., when doing areplace navigation,
activation.fromwill be the replaced entry).In that case, the entry will remain visible, but because it is
a "disposed" entry, its index will be -1 and attempting to
navigation.traverseTo()its key will be rejected.Initial discussion: whatwg/html#9760
Draft spec PR: whatwg/html#9856
I2p: https://groups.google.com/a/chromium.org/g/blink-dev/c/EfqxeH3Iwh4
Bug: 1492932
Change-Id: I2e090a8366906e4cb6778893ad9ffdca18d6ec37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4990011
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1220983}